Skip to content

Fix asset editors crashing when the container has no site #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakobploens wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix asset editors crashing when the container has no site #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion resources/js/Workspace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ export default class Workspace {

initializeEcho() {
const reference = this.container.reference.value.replaceAll('::', '.');
this.channelName = `${reference}.${this.container.site.value.replaceAll('.', '_')}`;
// Assets aren't site-scoped, so their publish container has no site.
// Fall back to a site-less channel instead of throwing on `.replaceAll`.
const site = this.container.site?.value;
this.channelName = site ? `${reference}.${site.replaceAll('.', '_')}` : reference;

const channelName = this.channelName;
debug(`Joining channel "${channelName}"`);
Expand Down