[6.x] Give nested sets and rows new ids when duplicating - #15190
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Give nested sets and rows new ids when duplicating#15190duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
`duplicateValues()` deep copies a row's values, regenerating `_id` on nested Replicator sets and Grid rows, and `attrs.id` on nested Bard sets, then rekeys the meta to match. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where duplicating a Replicator set, Grid row or Bard set didn't give any of the sets or rows nested inside it new ids, resulting in duplicate ids in the saved content.
This was happening because the duplicate methods deep copied the values verbatim, so anything nested inside kept its original
_id(orattrs.id, in Bard's case). The nested field meta was copied across unchanged too, leaving it keyed by the old ids.This PR fixes it by adding a
duplicateValues()method to theManagesRowMetamixin, which deep copies a row's values, regenerates the ids of anything nested within it, and rekeys its meta to match. The Replicator, Grid and Bard fieldtypes all use it when duplicating, as does Bard when pasting a set.Fixes #8438