[6.x] Ability to set an id for the checkboxes and being unique - #15172
Closed
SteJW wants to merge 1 commit into
Closed
[6.x] Ability to set an id for the checkboxes and being unique#15172SteJW wants to merge 1 commit into
SteJW wants to merge 1 commit into
Conversation
SteJW
changed the title
Member
|
Thanks for this. I think I'm going to make sure it gets folded into #15139 since they overlap pretty hard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a small PR for fixing collisions between checkboxes. They sometimes had the same id, because useId was being generated automatically by Vue. This created names like "reka-v-52". With having multiple bard sets and widgets, this caused the checkboxes to unclickable and/or enable a totally other checkbox.
Not the id looks like "field_page_content_2_attrs_values_page_builder_6_card_rounded_corners_0"