Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| :initial-sections="sections" | ||
| :show-section-collapsible-field="true" | ||
| @updated="sections = $event" | ||
| /> |
There was a problem hiding this comment.
Missing exclude-fieldset allows self-referencing fieldset imports
Medium Severity
The old code passed :exclude-fieldset="fieldset.handle" to the Fields component, which filtered the current fieldset out of the "Link Fields" dropdown to prevent self-referencing imports. The new code uses the Sections component, which doesn't accept or propagate an exclude-fieldset prop down to its inner Fields component. This allows users to link a fieldset to itself, which would cause a recursion error only caught at save time by validateRecursion().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds support for sections inside fieldsets and makes blueprint fieldset imports section-aware.
section_behaviorwithpreserve(default) orflatten.Notes
fields).References statamic/ideas#988
Note
Medium Risk
Introduces a new
sectionsstructure for fieldsets and changes how blueprint tabs expand imported fieldsets, which can affect persisted YAML shape and publish UI rendering. Risk is mitigated by normalization/back-compat handling and added test coverage, but impacts core field configuration flows.Overview
Fieldsets can now be authored and edited with sections, and the CP fieldset editor has been updated to use the shared
SectionsUI (including section/field drag-and-drop) while still collapsing a single default “Fields” section back to flatfieldson save.Blueprint fieldset imports are now section-aware: when importing a sectioned fieldset, imports can either preserve sections (expanding them into publish sections) or flatten them into the current section. The import UI exposes this via a new
Section Behaviorsetting and shows badges indicating when a linked fieldset has sections.Backend support includes fieldset normalization for legacy field syntax inside sections, new
has_sections/sections_countmetadata in fieldset props,FieldTransformersupport for serializingsection_behavior, and updated controllers/tests to cover section persistence, conversion between flat/sectioned forms, and publish expansion behavior.Written by Cursor Bugbot for commit 0889c06. This will update automatically on new commits. Configure here.