[6.x] Fix dated entries not syncing with origin revisions#14216
Open
duncanmcclean wants to merge 1 commit into6.xfrom
Open
[6.x] Fix dated entries not syncing with origin revisions#14216duncanmcclean wants to merge 1 commit into6.xfrom
duncanmcclean wants to merge 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where dated entries with non-localizable date fields become unsynced with their origin when using revisions.
This happens because when a localized entry is reconstructed from its working copy (via
makeFromRevision()), it would use the stale date stored in the revision instead of the current date from the origin entry.This meant that when the origin's date was changed and published, localized entries with working copies would continue showing the old date.
This PR fixes it by adding a check in
makeFromRevision()to determine whether the entry is the root, and whether the date field is marked as localizable. When an entry is a localization and the date field isn't localizable, the revision's date will be skipped, allowing the entry to inherit the date from the origin.Fixes #14132