[6.x] Only remove Bard set when backspace key is hit#14189
Open
duncanmcclean wants to merge 1 commit into6.xfrom
Open
[6.x] Only remove Bard set when backspace key is hit#14189duncanmcclean wants to merge 1 commit into6.xfrom
duncanmcclean wants to merge 1 commit into6.xfrom
Conversation
Contributor
|
This is nice. Had that happen in v5 also from time to time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where pressing any character key while a Bard set is selected would delete the set.
This was happening because TipTap/ProseMirror's default behavior for selected nodes is to replace them when typing.
This PR fixes it by adding keyboard shortcuts that intercept printable character keys (letters, numbers, punctuation) when a set node is selected, preventing accidental deletion.
Backspace and Delete keys still work normally for intentional removal.
Partially fixes #14185