[6.x] Use resize observer for the floating toolbar#14171
Closed
[6.x] Use resize observer for the floating toolbar#14171
Conversation
…than media queries. This is a similar implementation to the button group fieldtype
Contributor
|
Nice! There is a related PR at #13336 which solves this in a similar way for the action toolbar and the button group fieldtype. Is there any chance we could merge the two or extend this one to also cover button group fieldtypes? |
Contributor
Author
|
Oh! I actually thought that was already merged – hence me referring to it :) |
Member
|
I'd say lets stick to the other one. It solves the floating toolbar AND button group field usage on its own. |
Contributor
|
Alright, let me try and resolve the merge conflicts on that one then. |
Contributor
|
Updated the other pr and added a comment on whether to define a default value for overflow behavior. |
Contributor
Author
|
Closing this in favour of #13336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
We currently use a media query to switch to the "floating toolbar" layout for smaller viewports, where actions start to wrap.
While we could sort of get away with this before, the goal posts have changed now that we have keyboard shortcuts attached to items, resulting in the old layout persisting, even when items have wrapped.
Before fix

What this PR Does
After fix

How to Reproduce
cp/assetsand select something