Merged
Conversation
…therwise we can't differentiate between the placeholder in place when folders are being created and an error state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix #12457, improving the "create folder" interactions.
It's not quite perfect, but a lot better than the current UX.
gray-400rather thangray-500. While technically this is not quite as color-contrast accessible, on balance it feels more obvious that it's placeholder text now.So this is where it gets a little gnarly…
Since a Reka component is used here to manage the
[data-placeholder-shown], it becomes tricky to target the error state. There may be a better way, but I figured out I could add an error class to the hidden input, then target that with CSS.The only downside is that when entering a correct value, it will temporarily appear red before being created—I guess while the validation is happening and the error is being removed.