starknet_committer: name TrieReadTask lifetimes and document them

[yoavGrs]

The struct now uses 'indices / 'updates / 'storage instead of 'a / 'u /
's, and the doc comment explains why two non-storage lifetimes are
needed: unifying them would make the returned OriginalSkeletonForest
appear to borrow the storage update maps too, preventing the compute
phase from moving those maps by value.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

[reviewable-StarkWare]

This change is 

[yoavGrs]

• starknet_committer: name TrieReadTask lifetimes and document them #14239 👈 (View in Graphite)
• starknet_committer: derive skeleton updates from actual updates #14214
• starknet_committer: split commit_block into read and compute phases #14213
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Comment and lifetime-parameter naming only; no logic or data-flow changes.

Overview
Renames the generic lifetimes on TrieReadTask from opaque 'a / 'u / 's to 'indices, 'updates, and 'storage, and updates the struct doc and impl signatures to match (including OriginalSkeletonTreeImpl<'indices> in the task output type).

The doc comment now spells out why 'indices and 'updates must stay separate: merging them would make OriginalSkeletonForest look like it borrows the storage update maps, blocking commit_block from moving those maps by value into the compute phase. run_with_storage is reformatted only; behavior is unchanged.

^{Reviewed by Cursor Bugbot for commit 9597670. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[ArielElp]

@ArielElp reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

[graphite-app]

Merge activity

• May 29, 10:01 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.