Skip to content

apollo_consensus_orchestrator: pin SNIP-35 fee_target to override_l2_gas_price_fri when set#14230

Merged
ShahakShama merged 1 commit into
main-v0.14.3from
05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set
May 28, 2026
Merged

apollo_consensus_orchestrator: pin SNIP-35 fee_target to override_l2_gas_price_fri when set#14230
ShahakShama merged 1 commit into
main-v0.14.3from
05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Medium Risk
Changes proposer fee_proposal inputs for test/ops overrides; behavior is scoped to when override is set but affects consensus fee market proposals.

Overview
When override_l2_gas_price_fri is set in dynamic config, SNIP-35 fee_target is now taken from that override instead of the STRK/USD oracle. The oracle path is unchanged when the override is absent.

Fee-target logic is moved into resolve_fee_target, which compute_proposer_fee_proposal calls; metrics still record SNIP35_FEE_TARGET_FRI in both paths.

Reviewed by Cursor Bugbot for commit bc820f1. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from c27b590 to bb273c7 Compare May 28, 2026 08:00
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch 2 times, most recently from a9d3b48 to c4ac5ac Compare May 28, 2026 08:05
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from bb273c7 to cfefa39 Compare May 28, 2026 08:05
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch from c4ac5ac to fad5cf9 Compare May 28, 2026 08:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from cfefa39 to 728099a Compare May 28, 2026 08:14
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch from fad5cf9 to d44df8d Compare May 28, 2026 08:17
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from 728099a to 37cd335 Compare May 28, 2026 08:17
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 454 at r1 (raw file):

                let target = compute_fee_target(target_atto_usd_per_l2_gas, rate);
                match target {
                    Some(t) => SNIP35_FEE_TARGET_FRI.set_lossy(t.0),

Consider extracting the metric call outside of the function to reduce duplication

@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch from d44df8d to b70386d Compare May 28, 2026 08:38
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes branch from 37cd335 to 719af13 Compare May 28, 2026 08:38
@sirandreww-starkware sirandreww-starkware changed the base branch from 05-28-apollo_consensus_orchestrator_apollo_dashboard_add_usd_fee_target_panel_and_unit_suffixes to graphite-base/14230 May 28, 2026 08:58
@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch from b70386d to 1aa46d7 Compare May 28, 2026 09:02
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/14230 to main-v0.14.3 May 28, 2026 09:02
Copy link
Copy Markdown
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 05-28-apollo_consensus_orchestrator_pin_snip-35_fee_target_to_override_l2_gas_price_fri_when_set branch from 1aa46d7 to bc820f1 Compare May 28, 2026 09:14
@ShahakShama ShahakShama added this pull request to the merge queue May 28, 2026
Merged via the queue into main-v0.14.3 with commit d2f5442 May 28, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants