apollo_consensus_orchestrator: pin SNIP-35 fee_target to override_l2_gas_price_fri when set#14230
Conversation
PR SummaryMedium Risk Overview Fee-target logic is moved into Reviewed by Cursor Bugbot for commit bc820f1. Bugbot is set up for automated code reviews on this repo. Configure here. |
c27b590 to
bb273c7
Compare
a9d3b48 to
c4ac5ac
Compare
bb273c7 to
cfefa39
Compare
c4ac5ac to
fad5cf9
Compare
cfefa39 to
728099a
Compare
fad5cf9 to
d44df8d
Compare
728099a to
37cd335
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).
crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs line 454 at r1 (raw file):
let target = compute_fee_target(target_atto_usd_per_l2_gas, rate); match target { Some(t) => SNIP35_FEE_TARGET_FRI.set_lossy(t.0),
Consider extracting the metric call outside of the function to reduce duplication
d44df8d to
b70386d
Compare
37cd335 to
719af13
Compare
719af13 to
55cb23a
Compare
b70386d to
1aa46d7
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
@sirandreww-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
…gas_price_fri when set
1aa46d7 to
bc820f1
Compare

No description provided.