starknet_transaction_prover: finalize test recordings only after assertions pass

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_transaction_prover: finalize test recordings only after assertions pass #14212 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Test-only ordering change for when RPC recordings are saved; no production prover or executor behavior changes.

Overview
In virtual_snos_prover_test and virtual_block_executor_test, test_mode.finalize() is moved from immediately after the async/blocking work to after all success assertions (including proof verification in the prover test).

finalize() persists RPC recordings in recording mode; the change means offline RPC record files are written only when the test passes, not when execution or assertions fail.

^{Reviewed by Cursor Bugbot for commit ec54043. Bugbot is set up for automated code reviews on this repo. Configure here.}