apollo_storage: remove compiler backward compatibility marker#13313
Conversation
|
This change is |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| ClassManagerBlock = 7, | ||
| CompilerBackwardCompatibility = 8, | ||
| GlobalRoot = 9, | ||
| GlobalRoot = 8, |
There was a problem hiding this comment.
Renumbered serialization discriminant breaks existing stored data
High Severity
GlobalRoot serialization discriminant changed from 9 to 8 after removing CompilerBackwardCompatibility. Any existing database entries for GlobalRoot (stored as byte 9) will fail to deserialize, and any leftover CompilerBackwardCompatibility entries (stored as byte 8) will be misread as GlobalRoot. The discriminant for GlobalRoot needs to remain 9 to preserve backward compatibility with persisted data.
Additional Locations (1)
There was a problem hiding this comment.
Bump the storage version. @MohammadNassar1 is planning to break the storage too
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
@ShahakShama reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on MohammadNassar1).
| ClassManagerBlock = 7, | ||
| CompilerBackwardCompatibility = 8, | ||
| GlobalRoot = 9, | ||
| GlobalRoot = 8, |
There was a problem hiding this comment.
Bump the storage version. @MohammadNassar1 is planning to break the storage too
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
3 participants
Note
Medium Risk
Removes a persisted marker and shifts
MarkerKindserialization discriminants, which can break compatibility when reading existing DB/test fixtures or communicating with older nodes expecting the old enum layout.Overview
Removes the
CompilerBackwardCompatibilitymarker from storage APIs: drops itsMarkerKindvariant and deletes the corresponding read/write methods fromclass_managerand the marker request handling/tests.Updates
MarkerKindserialization/test enums to close the gap, renumberingGlobalRootto8to match the removed variant.Written by Cursor Bugbot for commit 6d84ecf. This will update automatically on new commits. Configure here.