echonet: chain parent hash from in-memory echonet blocks#13308
echonet: chain parent hash from in-memory echonet blocks#13308ron-starkware merged 1 commit intomainfrom
Conversation
8d3ecbb to
adc1a80
Compare
1c03422 to
de726bc
Compare
adc1a80 to
a43ba14
Compare
ayeletstarkware
left a comment
There was a problem hiding this comment.
@ayeletstarkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on ron-starkware).
echonet/echo_center.py line 371 at r1 (raw file):
} def _resolve_parent_block_hash(self) -> str:
what's the difference between this and the original func compute_current_and_previous_hash?
Code quote:
def _resolve_parent_block_hash(self) -> str:
ron-starkware
left a comment
There was a problem hiding this comment.
@ron-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on ayeletstarkware).
echonet/echo_center.py line 371 at r1 (raw file):
Previously, ayeletstarkware (Ayelet Zilber) wrote…
what's the difference between this and the original func
compute_current_and_previous_hash?
In compute_current_and_previous_hash it calculated the parent hash by doing +1 to the previous parent hash. Here, it takes the hash by looking at the previous block's hash (or the base block hash if there isn't one in the echonet storage)
de726bc to
3f5471f
Compare
34ac079 to
df7b475
Compare
ayeletstarkware
left a comment
There was a problem hiding this comment.
@ayeletstarkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on matanl-starkware).
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
3f5471f to
aced81c
Compare
df7b475 to
3f5e0e3
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
@matanl-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ayeletstarkware).
aced81c to
e83e190
Compare
3f5e0e3 to
a7e97ba
Compare
Made-with: Cursor
e83e190 to
cf590f7
Compare
a7e97ba to
cecc177
Compare
ron-starkware
left a comment
There was a problem hiding this comment.
@ron-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ron-starkware).


Resolve parent_block_hash from the latest in-memory stored block and fall back to the initialization base hash only when no blocks are stored.
Made-with: Cursor
Note
Medium Risk
Changes block linkage (
parent_block_hash) used by downstream consumers; incorrect resolution could break chain continuity in stored blocks, though the change is localized and has a clear fallback.Overview
Echo Center now sets
parent_block_hashfor newly stored blocks by looking up the most recent in-memory block inSharedContext, instead of deriving it deterministically from the configured base.This refactors
DeterministicChainto exposecompute_current_hash()(andbase_block_hash_hex) and updates block/state_update transformations to use the new API, removing the prior combined current/previous-hash helper.Written by Cursor Bugbot for commit cecc177. This will update automatically on new commits. Configure here.