apollo_mempool: reduce error logs to debug

[Itay-Tsabary-Starkware]

Note

Low Risk
Logging-only change that downgrades tracing::instrument error events from error to debug for key mempool APIs; no transaction handling logic is modified.

Overview
Reduces log severity noise in apollo_mempool by changing tracing::instrument annotations on get_txs, validate_tx, and add_tx so that returned errors are emitted at debug level instead of the default error level.

^{Written by Cursor Bugbot for commit 592fed7. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_mempool: reduce error logs to debug #13299 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TzahiTaub]

@TzahiTaub reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Itay-Tsabary-Starkware).

---

crates/apollo_mempool/src/mempool.rs line 281 at r1 (raw file):

    /// created.
    // TODO(AlonH): Consider renaming to `pop_txs` to be more consistent with the standard library.
    #[instrument(skip(self), err(level = "debug"))]

This should be reverted IMO. The only way to get an error here is if there is a nonce overflow, this shouldn't happen of course, and suggests a possible bug. The other two are fine as they do validations and a failure is expected.

Code quote:

 #[instrument(skip(self), err(level = "debug"))]

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on TzahiTaub).

---

crates/apollo_mempool/src/mempool.rs line 281 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

This should be reverted IMO. The only way to get an error here is if there is a nonce overflow, this shouldn't happen of course, and suggests a possible bug. The other two are fine as they do validations and a failure is expected.

If there's a bug/error there should be an explicit error message in the code itself.

[TzahiTaub]

@TzahiTaub resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).