apollo_dashboard: format pod alerts using metric structs + fix conflict test#13295
Merged
Itay-Tsabary-Starkware merged 1 commit intomain-v0.14.2from Mar 18, 2026
Conversation
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Itay-Tsabary-Starkware
force-pushed
the
03-16-apollo_dashboard_format_pod_alerts_using_metric_structs_fix_conflict_test
branch
from
08ebc89 to
d76e2ba
Compare
nadin-Starkware
approved these changes
Mar 17, 2026
Collaborator
nadin-Starkware
left a comment
nadin-Starkware
left a comment
There was a problem hiding this comment.
@nadin-Starkware reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Itay-Tsabary-Starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the PromQL strings used by pod-related infra alerts to be generated via metric structs/scoped filtering, which could affect alert firing if query formatting differs. Also broadens the global metric-name de-duplication test and updates metric scopes, which may cause CI failures if any downstream crates have conflicting names.
Overview
Refactors pod infra alert queries to use
apollo_metrics::define_metrics!+MetricQueryNamehelpers instead of hand-built strings and ad-hoc label-filter suffix replacement (notably for CrashLoopBackOff).Expands the metric-name duplication test to include additional component metric lists (including new
Podmetrics, Tokio metrics, and transaction-converter exports), and updatesMetricScopeto includePod(and reorderCompileToCasm).Updates
apollo_dashboarddev-dependencies to include additional crates needed for the expanded metric test.Written by Cursor Bugbot for commit d76e2ba. This will update automatically on new commits. Configure here.