Skip to content

Add_option_to_return_unrouded_builtin_counts_from_vm_runner#352

Open
YairVaknin-starkware wants to merge 1 commit into
mainfrom
yairv/add_option_to_return_unrouded_builtin_counts_from_vm_runner
Open

Add_option_to_return_unrouded_builtin_counts_from_vm_runner#352
YairVaknin-starkware wants to merge 1 commit into
mainfrom
yairv/add_option_to_return_unrouded_builtin_counts_from_vm_runner

Conversation

@YairVaknin-starkware
Copy link
Copy Markdown
Contributor

@YairVaknin-starkware YairVaknin-starkware commented May 28, 2026

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@YairVaknin-starkware YairVaknin-starkware force-pushed the yairv/add_option_to_return_unrouded_builtin_counts_from_vm_runner branch from c3ee9a1 to c871128 Compare May 28, 2026 08:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 60.20%. Comparing base (ea3b062) to head (dad14fb).

Files with missing lines Patch % Lines
crates/vm_runner/src/main.rs 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   59.19%   60.20%   +1.01%     
==========================================
  Files          35       35              
  Lines        5303     5307       +4     
==========================================
+ Hits         3139     3195      +56     
+ Misses       2164     2112      -52     
Files with missing lines Coverage Δ
crates/vm_runner/src/main.rs 92.50% <75.00%> (+92.50%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yael-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on YairVaknin-starkware).

@YairVaknin-starkware YairVaknin-starkware force-pushed the yairv/add_option_to_return_unrouded_builtin_counts_from_vm_runner branch 3 times, most recently from b1b79a6 to 488f2c8 Compare May 28, 2026 12:58
Copy link
Copy Markdown
Contributor Author

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YairVaknin-starkware reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on YairVaknin-starkware).

@YairVaknin-starkware YairVaknin-starkware force-pushed the yairv/add_option_to_return_unrouded_builtin_counts_from_vm_runner branch from 488f2c8 to dad14fb Compare May 28, 2026 13:40
Copy link
Copy Markdown
Contributor Author

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YairVaknin-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on YairVaknin-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants