fix: accept Docker Compose newer than 2.x in docker-compose start scripts#2504
Merged
Conversation
The start_dse69.sh / start_hcd.sh version gate matched the literal prefix "2.", so Compose releases past the 2.x line (e.g. 5.1.4) were rejected with "Docker compose v2 required". The intent was to reject Compose v1 — check the major version numerically (>= 2) instead. Also handle a missing/undiscoverable compose plugin gracefully: the old check leaked "unknown flag: --short" from the docker CLI before printing a misleading upgrade hint; the gate now reports the version it actually found (or "none").
Contributor
➡️ Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
➡️ Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
tatu-at-datastax
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
start_dse69.shandstart_hcd.shgate on Docker Compose v2 with:The regex matches the literal prefix
2., so any Compose release past the 2.x line — e.g. current Homebrewdocker-compose5.1.4 — is rejected with "Docker compose v2 required. Please upgrade Docker Desktop to the latest version." The original intent was to reject Compose v1, not to pin to 2.x forever.The old check also fails confusingly when the compose CLI plugin isn't discoverable at all (common with a brew-installed docker CLI, where the plugin lands in
/opt/homebrew/lib/docker/cli-plugins, a directory the CLI doesn't search by default):The change
Both scripts now parse the major version and require it to be >= 2, tolerate a leading
v, and report what was actually found when rejecting:docker compose version --short2.39.2v2.24.55.1.41.29.2unknown flag+ misleading hintfound: noneTest plan
bash -non both scripts./start_dse69.sh -dend-to-end with Compose 5.1.4 on macOS (colima): DSE container starts and reaches healthy via--wait./start_hcd.shsmoke run (same gate, identical change)