Make sure metadata() has correct value for num_chains#1187
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 91.21% 91.19% -0.02%
==========================================
Files 15 15
Lines 6121 6121
==========================================
- Hits 5583 5582 -1
- Misses 538 539 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@VisruthSK I think this windows run is failing at the spot that you changed in #1182 https://github.com/stan-dev/cmdstanr/actions/runs/25310119846/job/74194792020?pr=1187#step:13:7723 Seems like it's not deterministic. I think it also initially failed in your roxygen2 PR but then passed when I reran it (and it failed again after I merged it into master). Rerunning again now to see if it passes. We also have some non-determinism in the Mac tests that I'd like to sort out at some point (if possible). I tried at one point, but then got distracted with other work. I can try again at some point, or if you're interested you can take a look. Not super urgent. |
Submission Checklist
Summary
fixes #1186
Fixes
num_chainsinfit$metadata(). Previously it was always returning1. I suppose it should really bechainsinstead ofnum_chainsto match CmdStanR's arguments, but since we've been usingnum_chains(inherited from the CmdStan CSV names) I'll leave it asnum_chainsfor backwards compatibility.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: