Skip to content

Keep model_params to avoid breaking brms#1152

Merged
jgabry merged 2 commits intomasterfrom
revert-model_params-removal
Mar 9, 2026
Merged

Keep model_params to avoid breaking brms#1152
jgabry merged 2 commits intomasterfrom
revert-model_params-removal

Conversation

@jgabry
Copy link
Member

@jgabry jgabry commented Mar 9, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

closes #1151

Keep model_params in metadata for now due to usage in brms. See #1151 for details. Thanks to @anirban-mu for reporting the issue.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.97%. Comparing base (a8adbb1) to head (c27bc84).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files          14       14           
  Lines        5937     5938    +1     
=======================================
+ Hits         5223     5224    +1     
  Misses        714      714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry merged commit 4b54eab into master Mar 9, 2026
11 checks passed
@jgabry jgabry deleted the revert-model_params-removal branch March 9, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation of metadata$model_params in 0.9.0.9000 silently breaks brms

2 participants