Add tests for invalid bounds in density plotting functions#406
Merged
VisruthSK merged 2 commits intoforward-bounds-argumentfrom Dec 30, 2025
Merged
Add tests for invalid bounds in density plotting functions#406VisruthSK merged 2 commits intoforward-bounds-argumentfrom
VisruthSK merged 2 commits intoforward-bounds-argumentfrom
Conversation
Co-authored-by: VisruthSK <67435125+VisruthSK@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for invalid bounds in plotting function
Add tests for invalid bounds in density plotting functions
Dec 30, 2025
VisruthSK
reviewed
Dec 30, 2025
Member
VisruthSK
left a comment
There was a problem hiding this comment.
Lgtm, dunno if the syntax for expect_error is correct though. Will see on test fails
VisruthSK
added a commit
that referenced
this pull request
Dec 30, 2025
* Initial plan * Add tests for invalid bounds in plotting functions Co-authored-by: VisruthSK <67435125+VisruthSK@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: VisruthSK <67435125+VisruthSK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test coverage for error handling in
validate_density_boundsacross density plotting functions, addressing review feedback from #405.Changes
test-ppc-distributions.R: Added"density PPC/PPD plots reject invalid bounds"test blocktest-mcmc-distributions.R: Added"mcmc density plots reject invalid bounds"test blockCoverage
Tests verify all validation branches via
ppc_dens_overlayandmcmc_dens:c("a", "b"))c(0, 1, 2),1)c(0, NA),c(NA, 1))c(1, 0),c(1, 1))💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.