Update Slack detection approach#136
Open
stephenyeargin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr Upgraded to Hubot v14 + supported Slack adapter, the
adapterNamevalue changed. Need this to keep Slack detection working.This pull request refactors how the codebase detects and handles Slack adapters across multiple Hubot modules. It introduces a more robust and flexible
isSlackAdapterutility to check for Slack adapters, improving compatibility with various adapter names and reducing hardcoded checks. The update also includes new and expanded tests to ensure correct behavior. Additionally, there are minor documentation and manifest improvements.Slack Adapter Detection Refactor:
isSlackAdapterfunction inhubot-message-aggregator,hubot-slacklogs, andhubot-wisdomto detect Slack adapters by matching various possible adapter names, replacing previous strict equality checks. [1] [2] [3]hubot-message-aggregator,hubot-slacklogs, andhubot-wisdomto use the newisSlackAdapterfunction, ensuring Slack-specific logic only runs when appropriate. [1] [2] [3]Testing Improvements:
isSlackAdapterand initialization logic inhubot-message-aggregator/test/aggregation-module.test.jsto verify correct behavior for various adapter name scenarios. [1] [2] [3]Dependency and Manifest Updates:
acornandeslintas peer dependencies inhubot-message-aggregator/package-lock.jsonfor improved dependency management. [1] [2].flox/env/manifest.tomlto useschema-versioninstead ofversionfor manifest compatibility.Documentation:
README.md("collegues" → "colleagues").