fix: reset in between prop tests to fix flakiness#7252
Open
brice-stacks wants to merge 2 commits into
Open
Conversation
Otherwise, it was possible for the simnet and the model to get out of sync, causing flakiness in the tests.
Contributor
Author
|
Fixes #7251 |
There was a problem hiding this comment.
Pull request overview
This PR updates the SIP-031 stateful property test to reset simnet state between fast-check runs, preventing the model and simulated chain from drifting across generated cases.
Changes:
- Converts the stateful property test to async and reinitializes simnet before each generated command sequence.
- Recreates the model per property iteration while sharing command statistics across runs.
- Updates command-run reporting to accept the statistics map directly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
contrib/core-contract-tests/tests/sip-031/sip-031.stateful.prop.test.ts |
Adds per-run simnet reset and per-run model initialization for the SIP-031 stateful property test. |
contrib/core-contract-tests/tests/sip-031/commands/utils.ts |
Adjusts command-run reporting to consume the shared statistics map directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, it was possible for the simnet and the model to get out of sync, causing flakiness in the tests.
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo