Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (28.71%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #6984 +/- ##
===========================================
- Coverage 84.96% 84.85% -0.12%
===========================================
Files 412 412
Lines 219958 220426 +468
Branches 338 338
===========================================
+ Hits 186892 187037 +145
- Misses 33066 33389 +323
... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 23549394237Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| start_height: 254, | ||
| end_height: STACKS_EPOCH_MAX, | ||
| block_limit: HELIUM_BLOCK_LIMIT_20, | ||
| network_epoch: PEER_VERSION_EPOCH_3_4 |
There was a problem hiding this comment.
This needs to be PEER_VERSION_EPOCH_3_5
| | StacksEpochId::Epoch34 | ||
| | StacksEpochId::Epoch35 => { | ||
| // Epoch 2.5 and up compute reward sets, but *only* if PoX-4 is active | ||
| if burnchain |
There was a problem hiding this comment.
This match needs to be split into two blocks -- one match for epoch 2.5 through epoch 3.4 (inclusive), and one for epoch 3.5.
| } | ||
|
|
||
| pub fn from_pox_5_tuple(is_mainnet: bool, tuple: TupleData) -> Result<Self, ChainstateError> { | ||
| // PLACEHOLDER (rob-stacks) |
There was a problem hiding this comment.
Nit: Please don't pepper the codebase with comments like this @rob-stacks. Instead, please use either the issue tracker, or use Rust macros like todo!() or unimplemented!()
| addresses.sort_by_cached_key(|k| k.reward_address.to_burnchain_repr()); | ||
| } | ||
|
|
||
| // TODO [Pox5]: Use `Self::make_signer_set_pox_5` once Epoch 3.5 is fully working with pox-5 |
There was a problem hiding this comment.
Is there an issue for this TODO?
|
@hstove-stacks please remove @jcnelson as reviewer |
6 participants
This PR adds epoch 3.5, along with the epoch activation code that deploys a (stub) pox-5 contract.
This is built on top of #6928 along with a bunch of CI fixes, and some other changes from https://github.com/rob-stacks/stacks-core/commits/feat/epoch-3.5-and-pox-5/