refactor: Move stacks-codec into separate crate#6981
Merged
brice-stacks merged 5 commits intostacks-network:developfrom Apr 9, 2026
Merged
refactor: Move stacks-codec into separate crate#6981brice-stacks merged 5 commits intostacks-network:developfrom
stacks-codec into separate crate#6981brice-stacks merged 5 commits intostacks-network:developfrom
Conversation
|
|
Coverage Report for CI Build 24209411066Coverage decreased (-0.05%) to 85.666%Details
Uncovered Changes
Coverage Regressions1909 previously-covered lines in 65 files lost coverage.
Coverage Stats
💛 - Coveralls |
jcnelson
approved these changes
Apr 9, 2026
Merged
via the queue into
stacks-network:develop
with commit Apr 9, 2026
3617e52
324 of 330 checks passed
This was referenced Apr 10, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Clarinet currently we use a copy/pasted version of
stacks-codec. This is not a good way to share code, and I think the ideal way to handle it would be to publishstacks-codecon crates.ioTo do this, we need to refactor
stacks-codecinto it's own crate, and make sure it doesn't depend on any other parts of stacks-core. This PR simply movesstacks-codecout ofstacks-commonand into it's own crate, while re-exportingstacks-codecfromstacks-commonto avoid further changes in the code that currently uses itApplicable issues
stacks-codecfrom stacks-core stx-labs/clarinet#2226Additional info (benefits, drawbacks, caveats)
There may be other Stacks projects in Rust which can benefit from this
Checklist
docs/property-testing.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo