fix: Add periodic reconciliation to config-controller#20388
Draft
fix: Add periodic reconciliation to config-controller#20388
Conversation
The SecurityPolicy reconciler previously only ran on spec changes (generation-based event filter) with no periodic re-check. If the policy state in Central drifted (e.g., external deletion), the controller would not notice until the next pod restart or spec change. Return RequeueAfter on successful reconciliation so the controller periodically verifies that the desired state in Central matches the SecurityPolicy CRs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
🚀 Build Images ReadyImages are ready for commit 995d8c9. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-864-g995d8c9b25 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20388 +/- ##
==========================================
+ Coverage 49.56% 49.61% +0.04%
==========================================
Files 2794 2798 +4
Lines 212542 212878 +336
==========================================
+ Hits 105357 105615 +258
- Misses 99452 99525 +73
- Partials 7733 7738 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SecurityPolicy reconciler previously only ran on spec changes (generation-based event filter) with no periodic re-check. If the policy state in Central drifted (e.g., external deletion), the controller would not notice until the next pod restart or spec change.
Returns
RequeueAfter: 5mon successful reconciliation so the controller periodically verifies that the desired state in Central matches the SecurityPolicy CRs.User-facing documentation
Testing and quality
Automated testing
How I validated my change
go build ./config-controller/...compiles successfully