Skip to content

Conversation

@rhybrillou
Copy link
Contributor

@rhybrillou rhybrillou commented Jan 19, 2026

Description

PR stack:

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 19, 2026

Images are ready for the commit at 5752516.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-798-g5752516dbf.

@rhybrillou rhybrillou force-pushed the master-yann/plug-common-tokenbased-source branch from 934ec64 to 0a84d21 Compare January 19, 2026 16:02
@rhybrillou rhybrillou force-pushed the master-yann/implement-plugin-token-service branch from 9256d36 to 5752516 Compare January 19, 2026 16:02
@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 89.58333% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.01%. Comparing base (0a84d21) to head (5752516).

Files with missing lines Patch % Lines
central/auth/ocpplugin/service/singleton.go 43.75% 9 Missing ⚠️
central/auth/ocpplugin/service/service_impl.go 85.36% 6 Missing ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           master-yann/plug-common-tokenbased-source   #18545      +/-   ##
=============================================================================
+ Coverage                                      48.98%   49.01%   +0.02%     
=============================================================================
  Files                                           2632     2635       +3     
  Lines                                         197902   198046     +144     
=============================================================================
+ Hits                                           96947    97075     +128     
- Misses                                         93565    93581      +16     
  Partials                                        7390     7390              
Flag Coverage Δ
go-unit-tests 49.01% <89.58%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants