Improve in-stackrox-repo check, remove TODO

[mclasmeier]

Fix stackrox repository detection for forks and HTTPS clones

Check all remotes instead of only origin, and match both SSH and HTTPS URL variants with and without .git suffix. Fixes #91.

Summary by CodeRabbit

• Bug Fixes
  • Improved repository detection so the app recognizes StackRox GitHub remotes in more common URL formats.
  • Support now includes both SSH and HTTPS remote URLs, with or without a .git suffix, reducing false negatives.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: bd091b39-750f-44ab-9617-78e28ec91610

📥 Commits

Reviewing files that changed from the base of the PR and between 9de8b01 and acc9fee.

📒 Files selected for processing (2)

• internal/env/env.go
• internal/helpers/tag.go

👮 Files not reviewed due to content moderation or server errors (2)

• internal/helpers/tag.go
• internal/env/env.go

---

📝 Walkthrough

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately reflects the main change to stackrox repo detection.
Linked Issues check	✅ Passed	The PR addresses #91 by removing the TODO and updating repository detection as requested.
Out of Scope Changes check	✅ Passed	The changes stay focused on repo detection logic and tests, with no unrelated additions.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mc/stackrox-repo-check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

internal/env/env.go (1)

330-334: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

Matching is limited to two exact URL forms.

The helper only matches the scp-style SSH form (git@github.com:stackrox/stackrox) and the plain HTTPS form. Remotes using ssh://git@github.com/stackrox/stackrox, a trailing slash, or differing host case would not match and fall through to the default tag path. If those forms are realistic in your environments, consider normalizing further; otherwise this is fine as-is.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/env/env.go` around lines 330 - 334, The repository remote check in
isStackRoxRepositoryRemote is too strict and only matches two exact URL forms.
Update this helper to normalize additional realistic remote variants, such as
ssh://git@github.com/stackrox/stackrox, an optional trailing slash, and
host/path case differences, before comparing so valid StackRox remotes don’t
fall through to the default tag path.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@internal/env/env.go`:
- Around line 330-334: The repository remote check in isStackRoxRepositoryRemote
is too strict and only matches two exact URL forms. Update this helper to
normalize additional realistic remote variants, such as
ssh://git@github.com/stackrox/stackrox, an optional trailing slash, and
host/path case differences, before comparing so valid StackRox remotes don’t
fall through to the default tag path.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: b2a0b774-222a-4ac2-a905-079f705c8b37

📥 Commits

Reviewing files that changed from the base of the PR and between 189e745 and 51412bd.

📒 Files selected for processing (1)

• internal/env/env.go

[porridge]

This seems a bit fragile.. maybe it would be enough to check if the two last components are stackrox/stackrox? 🤔
Or even just the last one, so we allow clones of forks which don't have an upstream remote configured?

[mclasmeier]

What exactly do you consider to be fragile here?
I would imagine that checking for git@github.com:stackrox/stackrox and https://github.com/stackrox/stackrox covers 99% of the use-cases and ssh://git@github.com/stackrox/stackrox is (AFAIK) slightly more exotic, but valid as well.

So, unless we have clear indication (among our engineers) that some use-case is not covered, it would feel like over-engineering to me to try pushing this to 100%.

[porridge]

The fact that we need to match against the transport is, is fragile IMO.
I also think roxie should be usable for any stackrox developer, not just "our" Red Hat engineers. StackRox as a project is already passively hostile against upstream contributions because so many pieces of the workflow depend on having write access to the repo. Let's not make it worse?