Refactor rmdir hook#574
Open
JoukoVirtanen wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
is_monitoredwhen removing a directory from inode tracking is not needed since the inode will be in the map if it is monitored and not in the map if it is not monitored. A similar refactor does not work for unlinking files since the output ofis_monitoredis used to setargs.monitoredin that case and we need to know how it is monitored rather than if it is monitored or not in that case.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is sufficient.