Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3130 +/- ##
==========================================
+ Coverage 27.38% 27.51% +0.12%
==========================================
Files 95 95
Lines 5427 5478 +51
Branches 2548 2572 +24
==========================================
+ Hits 1486 1507 +21
- Misses 3214 3244 +30
Partials 727 727
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The initial content of this PR was authored using Claude Code.
Description
For scalability reasons, Collector filters addresses in a different way when they are "public" or "private". In particular, addresses in the "public" ranges are aggregated and don't appear individually on the Network Graph.
We have seen a few occurrences of customers making use of non "private" addresses for the PODs and services of their clusters ; leading to internal traffic not appearing as expected in the interface.
This PR enumerates the local network interfaces and displays the addresses with associated netmask. When a non "private" address is found, a warning message is produced.
This is expected to be useful when troubleshooting because the addresses where not available in the log before, but also, the customers may be able to fix the situation by themselves.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.
For more details, ref the Confluence page about this section.