Skip to content

feat(vmcp): expose active backend sessions on /status endpoint#4019

Open
yrobla wants to merge 1 commit intomainfrom
issue-3876
Open

feat(vmcp): expose active backend sessions on /status endpoint#4019
yrobla wants to merge 1 commit intomainfrom
issue-3876

Conversation

@yrobla
Copy link
Contributor

@yrobla yrobla commented Mar 5, 2026

Add session visibility to the /status endpoint for operational debugging and compliance auditing when sessionManagementV2 is enabled.

Closes: #3876

@yrobla yrobla requested a review from Copilot March 5, 2026 15:28
@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Mar 5, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00fd4857c7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds session visibility to the vMCP /status endpoint to support operational debugging and compliance auditing when SessionManagementV2 is enabled.

Changes:

  • Extend /status response schema to optionally include active vMCP sessions and backend session ID mappings.
  • Add ListActiveSessions() to the session manager and expose the data through buildStatusResponse.
  • Add unit tests for ListActiveSessions() behavior and a regression test that sessions is omitted when V2 is disabled.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
pkg/vmcp/server/status.go Adds optional sessions block to /status when SessionManagementV2 is enabled.
pkg/vmcp/server/status_test.go Updates status response test DTOs; adds tests for sessions omission and backend field redaction.
pkg/vmcp/server/sessionmanager/session_manager.go Introduces SessionInfo and implements ListActiveSessions().
pkg/vmcp/server/sessionmanager/list_sessions_test.go Adds tests for listing behavior across empty, placeholder-only, and populated stores.
pkg/vmcp/server/session_manager_interface.go Extends the SessionManager interface with ListActiveSessions().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.63%. Comparing base (e758073) to head (00098b1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/vmcp/server/sessionmanager/session_manager.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4019      +/-   ##
==========================================
+ Coverage   68.60%   68.63%   +0.02%     
==========================================
  Files         444      444              
  Lines       45178    45223      +45     
==========================================
+ Hits        30995    31037      +42     
- Misses      11781    11783       +2     
- Partials     2402     2403       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Mar 5, 2026
Add session visibility to the /status endpoint for operational debugging
and compliance auditing when sessionManagementV2 is enabled.

Closes: #3876
@github-actions github-actions bot added size/L Large PR: 600-999 lines changed and removed size/M Medium PR: 300-599 lines changed labels Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large PR: 600-999 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[vMCP] Expose active backend sessions on health endpoint

3 participants