Add E2E tests for skills overwrite protection and CLI#4010
Open
Add E2E tests for skills overwrite protection and CLI#4010
Conversation
Add missing E2E test coverage for the skills lifecycle (issue #3655): - Overwrite protection: test duplicate install returns 409, reinstall after uninstall succeeds, and force flag allows overwrite - Build + validate lifecycle: validate then build the same skill dir - CLI-level E2E tests: new cli_skills_test.go testing the full thv skill CLI → REST API → service flow including validate, build, install, list, info, uninstall, and a full lifecycle test Closes #3655 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
JAORMX
requested review from
ChrisJBurns,
amirejaz,
eleftherias,
jhrozek,
lujunsan,
rdimitrov and
yrobla
as code owners
The E2E CI matrix filters by label (core, mcp, api, etc). Without the "api" label, CLI skills tests would not run in any CI job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
==========================================
- Coverage 68.63% 68.63% -0.01%
==========================================
Files 439 439
Lines 44868 44868
==========================================
- Hits 30797 30793 -4
- Misses 11678 11682 +4
Partials 2393 2393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The force flag controls filesystem overwrite of unmanaged directories, not DB duplicate bypass. A duplicate install with force still returns 409 because the DB record already exists. Updated the test expectation to match this behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
size/S
reyortiz3
reviewed
Mar 5, 2026
reyortiz3
approved these changes
Mar 5, 2026
rdimitrov
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3655
All server wiring, service implementation, handlers, and CLI commands were already complete. This PR adds the missing E2E test coverage identified in the acceptance criteria:
cli_skills_test.go): teststhv skillcommands (validate, build, install, list, info, uninstall) via the compiled binary withTOOLHIVE_API_URLpointing to a test server — proving the full CLI → REST API → service flowTest plan
LABEL_FILTER=skills)🤖 Generated with Claude Code