Return 401 with WWW-Authenticate for expired upstream tokens#3984
Open
Return 401 with WWW-Authenticate for expired upstream tokens#3984
Conversation
When upstream tokens are expired or missing, return a clear 401 with WWW-Authenticate header instead of silently passing the request through with an invalid token. Related: #3914
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3984 +/- ##
=======================================
Coverage 68.56% 68.56%
=======================================
Files 437 437
Lines 44662 44673 +11
=======================================
+ Hits 30621 30630 +9
Misses 11657 11657
- Partials 2384 2386 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upstream tokens are expired or missing, return a clear 401 with WWW-Authenticate header instead of silently passing the request through with an invalid token.
Related: #3914