Surface reconciliation errors in MCPServer status#3983
Open
Conversation
Several error paths (RBAC, authz ConfigMap, RunConfig, deployment creation) only logged errors without updating the MCPServer status, leaving it stuck at Phase=Pending with no indication of the failure. Surface errors by setting Phase=Failed with a descriptive message, following the existing pattern from handleToolConfig. Also guard updateMCPServerStatus from overwriting a Failed phase back to Pending.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
- Coverage 68.56% 68.52% -0.04%
==========================================
Files 437 437
Lines 44662 44689 +27
==========================================
+ Hits 30621 30623 +2
- Misses 11657 11685 +28
+ Partials 2384 2381 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several error paths (RBAC, authz ConfigMap, RunConfig, deployment creation) only logged errors without updating the MCPServer status, leaving it stuck at Phase=Pending with no indication of the failure.
Surface errors by setting Phase=Failed with a descriptive message, following the existing pattern from handleToolConfig. Also guard updateMCPServerStatus from overwriting a Failed phase back to Pending.