Skip to content

Surface reconciliation errors in MCPServer status#3983

Open
jhrozek wants to merge 1 commit intomainfrom
operator-surface-reconcile-errors
Open

Surface reconciliation errors in MCPServer status#3983
jhrozek wants to merge 1 commit intomainfrom
operator-surface-reconcile-errors

Conversation

@jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Mar 3, 2026

Several error paths (RBAC, authz ConfigMap, RunConfig, deployment creation) only logged errors without updating the MCPServer status, leaving it stuck at Phase=Pending with no indication of the failure.

Surface errors by setting Phase=Failed with a descriptive message, following the existing pattern from handleToolConfig. Also guard updateMCPServerStatus from overwriting a Failed phase back to Pending.

Several error paths (RBAC, authz ConfigMap, RunConfig, deployment
creation) only logged errors without updating the MCPServer status,
leaving it stuck at Phase=Pending with no indication of the failure.

Surface errors by setting Phase=Failed with a descriptive message,
following the existing pattern from handleToolConfig. Also guard
updateMCPServerStatus from overwriting a Failed phase back to Pending.
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 3, 2026
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.52%. Comparing base (c46ae47) to head (6c2a1fd).

Files with missing lines Patch % Lines
...d/thv-operator/controllers/mcpserver_controller.go 15.62% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3983      +/-   ##
==========================================
- Coverage   68.56%   68.52%   -0.04%     
==========================================
  Files         437      437              
  Lines       44662    44689      +27     
==========================================
+ Hits        30621    30623       +2     
- Misses      11657    11685      +28     
+ Partials     2384     2381       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant