Respect INSECURE_DISABLE_URL_VALIDATION in upstream auth HTTP client#3981
Open
Respect INSECURE_DISABLE_URL_VALIDATION in upstream auth HTTP client#3981
Conversation
UserInfoConfig.Validate() and newHTTPClientForHost() did not check the INSECURE_DISABLE_URL_VALIDATION env var, unlike the rest of the networking validation code. This caused the embedded auth server to reject non-localhost HTTP userinfo URLs and block requests to in-cluster services on private IPs, even when the env var was explicitly set.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3981 +/- ##
==========================================
+ Coverage 68.56% 68.57% +0.01%
==========================================
Files 437 437
Lines 44662 44664 +2
==========================================
+ Hits 30621 30628 +7
+ Misses 11657 11652 -5
Partials 2384 2384 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserInfoConfig.Validate() and newHTTPClientForHost() did not check the INSECURE_DISABLE_URL_VALIDATION env var, unlike the rest of the networking validation code. This caused the embedded auth server to reject non-localhost HTTP userinfo URLs and block requests to in-cluster services on private IPs, even when the env var was explicitly set.