fix(rabbitmq, redis): add modify plan functions - #1684
Open
GokceGK wants to merge 1 commit into
Open
Conversation
relates to STACKITTPR-804
8 tasks
| resp.TypeName = req.ProviderTypeName + "_rabbitmq_instance" | ||
| } | ||
|
|
||
| // ModifyPlan implements resource.ResourceWithModifyPlan. |
Contributor
There was a problem hiding this comment.
Let's remove these comments, we usually don't have these on the functions
Contributor
Author
There was a problem hiding this comment.
hmm, many resources have this comment in the modifyPlan function, that is why I also kept.
| resp.TypeName = req.ProviderTypeName + "_rabbitmq_credential" | ||
| } | ||
|
|
||
| // ModifyPlan implements resource.ResourceWithModifyPlan. |
Contributor
There was a problem hiding this comment.
here as well remove
| resp.TypeName = req.ProviderTypeName + "_redis_credential" | ||
| } | ||
|
|
||
| // ModifyPlan implements resource.ResourceWithModifyPlan. |
| resp.TypeName = req.ProviderTypeName + "_redis_instance" | ||
| } | ||
|
|
||
| // ModifyPlan implements resource.ResourceWithModifyPlan. |
Contributor
There was a problem hiding this comment.
And here as well 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-804
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)