Amphorae build fixes#2436
Conversation
04a9fe0 to
22fa65b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the Octavia Amphora image build playbook by setting the amphora_dib_upper_constraints_file variable to an empty string and moving python3-venv from common packages to OS-specific packages. The review feedback highlights two issues: first, python3-venv does not exist on RedHat-based systems and will cause installation failures, so it should be removed from the RedHat package list. Second, hardcoding amphora_dib_upper_constraints_file to an empty string prevents user overrides due to Ansible's variable precedence, and using a default filter is recommended instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
python3-venv is not available on RH family systems.
22fa65b to
cf8d441
Compare
1 participant
Arguably, we should be using the latest DIB and not pinned to the OpenStack release. This ensures recent OS versions compatibility and generic fixes and improvements included.
Also, fix Ubuntu vs. Rocky dependencies installation.