Build Rocky Linux 10 container images#2252
Draft
owenjones wants to merge 1 commit intostackhpc/2025.1from
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables Epoxy container image builds on Rocky Linux 10 by adding the required repository configurations, version variables, and image customizations. It also introduces Valkey support for Rocky 10 while maintaining Redis for older distributions. Feedback highlights critical issues where YAML block scalars incorrectly convert lists into strings, which would break Jinja2 loops during the build process. Additionally, the review identifies shell variable escaping and indentation errors in a manually generated repository file, and suggests a more robust method for accessing version-specific customizations.
owenjones
force-pushed
the
rl10/container-images
branch
from
c838aee to
ad3c5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.