Fix rocky 9 overcloud host image minor version#2082
Fix rocky 9 overcloud host image minor version#2082elelaysh merged 2 commits intostackhpc/2025.1from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to specify the minor version for the Rocky 9 overcloud host base image, moving from a major version tag (e.g., rockylinux:9) to a more specific one (e.g., rockylinux:9.6). This is achieved by introducing a new build argument ROCKY_MINOR_DOT_VERSION in the DIB image build process.
My review identifies a critical issue with how the build argument is constructed, which could lead to build failures when a minor version is not specified. I've provided a suggestion to fix this. Additionally, I've pointed out a maintainability concern regarding the use of a branch name for a dependency, recommending a switch to a specific commit or tag for better stability.
|
See stackhpc/stackhpc-image-elements#73 |
elelaysh
force-pushed
the
feat/overcloud-push-to-local-first
branch
from
0659206 to
41d9b72
Compare
elelaysh
force-pushed
the
feat/overcloud-push-to-local-first
branch
from
f034b08 to
6678ffb
Compare
|
Workflow building the overcloud host image: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/20954129314 |
Previously rockylinux/rockylinux:9 was used. As soon as a new release was tagged in the docker hub it would be used
elelaysh
force-pushed
the
feat/overcloud-push-to-local-first
branch
from
6678ffb to
65cdf70
Compare
3 participants
Ensure we use the right tag (eg.
rockylinux:9.6) docker base image,instead of just the major version (eg.
rockylinux:9).