Ci hardening - #608
Merged
Merged
Conversation
* ci: Bump actions/checkout to v7.0.0 * ci: Add explicit permissions to jobs * ci: Conditionally install host dependencies without cache * ci: Conditionally set rust-cache lookup-only * ci: Skip publish jobs for forks * ci: Remove checkout step from notify job
Techassi
self-requested a review
July 14, 2026 18:10
* Prevent notification on cancelled workflows * Update failure condition to check job results * Add missing job dependencies to notify job * Validate required jobs in finished job * Fix detect-changes globs to cover subdirectory Rust sources * Match dependency versions across templates * Guard publish/provenance jobs with stackabletech owner check * Fix daily security workflow
Techassi
reviewed
Aug 4, 2026
Techassi
left a comment
Techassi
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me, thanks!
Just a few minor comments.
Techassi
previously approved these changes
Aug 5, 2026
Member
|
Ah, seems like a yamllint issue must be fixed. |
Member
|
Oh man, now a merge conflict must be resolved 🙈 |
Contributor
Author
I've just seen this now :/ ... but fixed :) |
Techassi
previously approved these changes
Aug 7, 2026
Contributor
Author
|
@Techassi just had to merge another commit due to a conflict |
Techassi
approved these changes
Aug 7, 2026
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a collection of 'correctness fixes' and 'hygiene' improvements to the CI templates:
Including: