Skip to content

chore(webhook): Hide ByteString in instrumentation #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Techassi merged 2 commits into from
Jan 12, 2026
Merged

chore(webhook): Hide ByteString in instrumentation #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2154f
chore(webhook): Hide ByteString in instrumentation
Techassi Jan 12, 2026
9d687ce
chore(webhook): Also hide the ByteString in the rotation handlers
Techassi Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/stackable-webhook/src/webhooks/conversion_webhook.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ impl<H> ConversionWebhook<H> {
}

#[instrument(
skip(self, crd, crd_api),
skip(self, crd, crd_api, new_ca_bundle),
fields(
name = crd.name_any(),
kind = &crd.spec.names.kind
Expand Down Expand Up @@ -244,7 +244,7 @@ where
self.options.disable_crd_maintenance
}

#[instrument(skip(self))]
#[instrument(skip(self, new_ca_bundle))]
async fn handle_certificate_rotation(
&mut self,
new_ca_bundle: &ByteString,
Expand Down
2 changes: 1 addition & 1 deletion crates/stackable-webhook/src/webhooks/mutating_webhook.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ where
self.options.disable_mwc_maintenance
}

#[instrument(skip(self))]
#[instrument(skip(self, new_ca_bundle))]
async fn handle_certificate_rotation(
&mut self,
new_ca_bundle: &ByteString,
Expand Down
Loading