ci: add PR workflows, pre-commit, release updates, and build fixes - #35
ci: add PR workflows, pre-commit, release updates, and build fixes#35Saul-STFC wants to merge 3 commits into
Conversation
|
Thanks. Does this supersede #33? |
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Techassi
moved this from Development: Done
to Development: In Review
in Stackable Engineering
Yes it does :) |
| uses: actions/setup-java@0f481fcb613427c0f801b606911222b5b6f3083a # v5.5.0 | ||
| with: | ||
| java-version: '22' | ||
| distribution: 'zulu' |
There was a problem hiding this comment.
We drop caching, I assume the reasoning is cache poisoning?
| clean verify | ||
|
|
||
|
|
||
| - name: Upload NAR Artifact |
There was a problem hiding this comment.
Any particular reason to keep the artifact? I assume debugging/testing?
Downstream consumers must use a tagged version anyway.
There was a problem hiding this comment.
Just debugging, but I can remove if needed?
There was a problem hiding this comment.
I'm personally happy to leave it in. CC'ing @lfrancke and @sbernauer.
There was a problem hiding this comment.
I only looked at this part and nothing else: I'd say this can (or maybe even should?) go.
We have never needed this so far and if this builds for every PR, also externals people could publish something under our name. Even if it's transient. Not a super strong opinion though.
Thanks for pinging me.
There was a problem hiding this comment.
I assume this file only includes whitespace changes?
Co-authored-by: Techassi <git@techassi.dev>
4 participants
This PR introduces foundational CI/CD pipelines and code quality tooling for our Java repositories. Once merged, this standard setup can serve as a template to bereplicated across our other Java repos.
Changes:
• Added automated PR checks (pr_build.yaml, pr_prek.yaml) to build and validate code on every pull request.
• Pinned GitHub Action hashes and converted simpler steps to native GitHub commands where actions were unnecessary.
• Configured .pre-commit-config.yaml with rules for yamllint and markdownlint to enforce formatting (mirroring other repos)
• Applied the new linting rules across the existing codebase
• Added a maven wrapper (mvnw) and its associated wrapper files to guarantee a consistent Maven version across all development and CI environments.
• Removed unused dummy tests (AppTest.java) and redundant files.