chore: Sync the vendored UI with upstream antora-ui-default, part 2: JS and a11y ports - #920
Merged
Conversation
…f menu panel is missing
- prevents highlight.js from logging a warning about the unknown language "none"
…tate Upstream did this in header-content.hbs (b35fcda, 86237c9), a partial this repo replaced with its own header.hbs, so the change could not be ported and is reapplied here. Ours targets the popup-menu container rather than upstream's topbar-nav. The button previously had no accessible name at all, and nothing exposed its open/closed state; 05-mobile-navbar.js already maintains aria-expanded and now reads aria-controls, falling back to data-target. Co-Authored-By: Claude <noreply@anthropic.com>
Companion to upstream's def7144, which guards the same script against a missing article.doc. Upstream needs no toolbar guard because every one of its layouts has one; our landing layout does not, so jumpToAnchor could throw on a page that has an article but no toolbar. Treats an absent toolbar as a zero offset rather than returning early, so anchor links keep working instead of silently doing nothing. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
lfrancke
marked this pull request as ready for review
August 12, 2026 21:40
xeniape
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
xeniape
self-requested a review
August 13, 2026 08:24
Co-authored-by: Xenia <xenia.fischer@stackable.tech>
Member
Author
|
Thanks for the review and the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of the vendored-UI re-sync with upstream, following #906
This PR focuses on the JS and accessibility stuff (after this we have CSS left)
Similar to last time: CLA checks will fail by design so I'll manually merge this but still want a review. See #906 for details.
User-visible
One new feature and it's not very exciting. The ToC that appears on content pages now has a expand/collabse button on hover.
The rest is mostly bugs for edge cases (switching from mobile to desktop view, a console warning and so on).
Four upstream commits did not land
Note
This section is entirely Claude generated and can be ignored. I left it in as a reference should we ever wonder why a certain commit isn't included.
fb151724(overscroll) — already present in all four affected places.2bcdc3a2(nav resilience) — already applied;git amdetected it.9c6d2489(highlight.jsnonelanguage) — superseded byda14ed68, which is in this PR. Untagged blocks are no longer passed to highlight.js at all, so there is no unknown-language warning left to fix. Upstream made the same move itself, from definingnonein 2022-03 to skipping untagged blocks in 2022-07.cdd7b764(scrollbar normalisation) — deferred. It needs two colour variables that do not exist yet (--scrollbar-track-color,--scrollbar_hover-thumb-color), and picking values is a design decision in a file the planned token work will rewrite. The@media (pointer: fine)gating in it is worth taking separately.