Skip to content

perf: Give the navbar and footer logos explicit dimensions #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lfrancke wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

perf: Give the navbar and footer logos explicit dimensions #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ui/src/css/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,23 @@ body {
word-wrap: normal;
}

/* The img carries width/height attributes so its space is reserved before it
* loads. Two consequences to keep in mind when touching this rule:
*
* width: auto is required, not redundant. Those attributes are presentational
* hints that set a real width, so without it the logo renders at its full 199px
* against a 22px height and stretches by a third. Setting it hands sizing back
* to the aspect ratio the attributes imply.
*
* The gap is a margin, not padding, because aspect-ratio sizes the box named by
* box-sizing -- border-box here -- so padding would count inside the ratio and
* squash the image by exactly that much. */
.navbar-brand .navbar-item:first-child img {
height: 22px;
width: auto;
display: inline-block;
margin-top: -4px;
padding-right: 20px;
margin-right: 20px;
}

.navbar-brand .navbar-item.documentation-link {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/partials/footer-content.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- link columns -->
<div class="footer-info">
<div class="footer-info-item-large">
<img src="{{{uiRootPath}}}/img/logo-2-1.png">
<img src="{{{uiRootPath}}}/img/logo-2-1.png" width="150" height="26">
<p class="footer-motto">
your data, your platform
</p>
Expand Down
2 changes: 1 addition & 1 deletion ui/src/partials/header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<nav class="navbar">
<div id="topbar-left" class="navbar-brand">
<a class="navbar-item" href="{{{ relativize (versioned "home" page "index.html") }}}">
<img src="{{{uiRootPath}}}/img/stackable-logo.png">
<img src="{{{uiRootPath}}}/img/stackable-logo.png" width="199" height="30">

@xeniape xeniape Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

That looks weirdly stretched

</a>
<a class="navbar-item documentation-link" href="{{{ relativize (versioned "home" page "index.html") }}}">
Docs
Expand Down
Loading