refactor: move extensions to their own packages#1650
Conversation
0dd6a1c to
f4414e6
Compare
jsignell
left a comment
There was a problem hiding this comment.
Whoa. I love it 😍
The only part that is hitting me a little weird is that the extension logic is nested under pystac/extensions. Aside from that looking a little odd I am also wondering if there is a risk of a conflicting file existing in pystac core.
Yeah, it's a good point, though if we move those files ( |
|
Just for sake of example, the latest release-please PR (#1632) is a good illustration of why splitting extensions is good:
I don't think the storage extension should bump our MINOR. |
jsignell
left a comment
There was a problem hiding this comment.
This looks great! Just a few little comments

This is a proposed refactor of each extension into its own Python package. Basic idea goes like this:
pystac-core, but keep the code and import paths the samepystacthat depends on everythingThis should keep the install story and API identical, while simultaneously de-coupling our extension versions from our main PySTAC version.
Opening as a draft to get a smell check on the idea.
Note
I've disabled the benchmark CI for the time being to get things green, as
asvis cranky with the new setup.