This repository was archived by the owner on Mar 18, 2021. It is now read-only.
Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses#900
Open
point-source wants to merge 3 commits intostablekernel:masterfrom
Open
Fix #899: Don't try to rename ops ids from ManagedObjectController subclasses#900point-source wants to merge 3 commits intostablekernel:masterfrom
point-source wants to merge 3 commits intostablekernel:masterfrom
Conversation
Author
|
Hmm seems this doesn't result in valid openapi spec under some conditions. Will continue to work on it. Don't merge yet. |
point-source
changed the title
Author
|
Okay, this should be safe now. Actually maybe safer than the original implementation and I confirmed it still works with the openapi sdk generator. It is also much clearer about what it is actually doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899