Expand manifest-parser ecosystem coverage (#702) - #1050
Merged
Conversation
Adds Modern Python (pyproject.toml/poetry.lock/Pipfile), .NET (NuGet packages.config/*.csproj), C/C++ (Conan/vcpkg), Gradle, CocoaPods, Swift Package Manager, Dart/Flutter (pubspec.yaml), and JS/TS alternative lockfiles (yarn.lock/pnpm-lock.yaml) to UniversalManifestSlicer's SBOM extraction and physical-package location, plus extends ManifestParser's supply-chain security auditing to pyproject.toml, yarn.lock, and Gradle build scripts. Introduces SUPPORTED_MANIFEST_SUFFIXES alongside the existing exact-name SUPPORTED_MANIFEST_FILENAMES set, since *.csproj files are named per-project rather than with one fixed filename; wired into both manifest-discovery call sites (galaxyscope Phase 10, SbomRecorder's standalone fallback), which previously only matched exact filenames. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UniversalManifestSlicer(SBOM dependency extraction + physical on-disk verification) to cover the ecosystems requested in Feature Request: Expand Ecosystem Coverage in Manifest Parser #702: Modern Python (pyproject.toml/poetry.lock/Pipfile), .NET/NuGet (packages.config/*.csproj), C/C++ (conanfile.txt/vcpkg.json), Gradle (build.gradle/.kts), CocoaPods (Podfile), Swift Package Manager (Package.swift), Dart/Flutter (pubspec.yaml), and JS/TS alternative lockfiles (yarn.lock/pnpm-lock.yaml).ManifestParser's supply-chain security auditing (direct git/URL dependency refs, insecure/non-standard registries) topyproject.toml,yarn.lock, and Gradle build scripts, per the issue's "Security Auditing" ask.SUPPORTED_MANIFEST_SUFFIXESalongside the existing exact-nameSUPPORTED_MANIFEST_FILENAMES, since*.csprojfiles are named per-project rather than with one fixed filename. Wired into both manifest-discovery call sites (galaxyscope.pyPhase 10's stem_map filter,SbomRecorder's standalone root-only fallback), which previously only matched exact filenames and would have silently dropped wildcard manifests.Closes #702.
Test plan
tests/tools_recorders/test_sbom_generator.py(slicing + physical-locate for every new ecosystem, updated drift-guard tests) andtests/core_engine/test_manifest_parser.py(new security-audit coverage for pyproject.toml/yarn.lock/Gradle)python -m pytest tests/— 5447 passed, 0 failedruff format --checkcleanpython tests/tools/audit_check.pyclean (baseline regenerated only for pure line-shifts from inserted code, no new genuine findings)🤖 Generated with Claude Code