Skip to content

Bug 5538: Do not update Content-Length from 304 responses #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bowling233 wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Open

Bug 5538: Do not update Content-Length from 304 responses #2401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d0df29
Do not update Content-Length from 304 responses
bowling233 Apr 5, 2026
030e2b2
Add Baolin Zhu to CONTRIBUTORS
bowling233 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ Thank you!
Assar Westerlund <assar@pdc.kth.se>
Axel Westerhold <ml.awesterhold@dts.de>
Aymeric Vincent <aymericvincent@free.fr>
Baolin Zhu <zhubaolin228@gmail.com>
Barry Dobyns <barry@dobyns.com>
Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
Benjamin Kerensa <bkerensa@ubuntu.com>
Expand Down
6 changes: 5 additions & 1 deletion src/HttpHeader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,11 @@ HttpHeader::skipUpdateHeader(const Http::HdrType id) const
return
// TODO: Consider updating Vary headers after comparing the magnitude of
// the required changes (and/or cache losses) with compliance gains.
(id == Http::HdrType::VARY);
(id == Http::HdrType::VARY) ||
// RFC 9111 Section 3.2 explicitly excludes Content-Length
// from the "MUST add ..., replacing already present" list. Also,
// broken servers are known to send Content-Length:0 in their 304s.
(id == Http::HdrType::CONTENT_LENGTH);
Comment thread
bowling233 marked this conversation as resolved.
}

void
Expand Down
Loading