Skip to content

Add paging support to Rootly- incidents datastream#64

Open
noorulkhan-n wants to merge 4 commits into
mainfrom
feature/rootly_paging
Open

Add paging support to Rootly- incidents datastream#64
noorulkhan-n wants to merge 4 commits into
mainfrom
feature/rootly_paging

Conversation

@noorulkhan-n

@noorulkhan-n noorulkhan-n commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

📋 Summary

  • Added offset-based paging support for the incidents datastream.
  • Configured page size and offset handling to retrieve all records across multiple pages.
  • Ensures incident imports continue correctly when API responses exceed a single page.

🧩 Plugin details

  • Plugin name:

  • Type of change:

    • Bug fix
    • New datastream
    • Enhancement to existing datastream
    • Performance improvement
    • Documentation / metadata / logo
    • Other (please describe)

⚠️ Breaking changes

  • No
  • Yes (please describe)

📚 Documentation

  • No documentation changes needed
  • Documentation updated

✅ Checklist

  • No secrets or credentials included
  • Plugin, datastream and UI naming follow SquaredUp guidelines
  • I agree to the Code of Conduct

@noorulkhan-n noorulkhan-n requested a review from a team June 16, 2026 05:59
@noorulkhan-n noorulkhan-n added the enhancement New feature or request label Jun 16, 2026
@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review

@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

Hi @noorulkhan-n - please update the PR description to use one of the templates in the current PR description.

@noorulkhan-n

Copy link
Copy Markdown
Contributor Author

@clarkd updated the description now

@clarkd

clarkd commented Jun 17, 2026

Copy link
Copy Markdown
Member

@claude review once

Comment thread plugins/Rootly/v1/metadata.json

@clarkd clarkd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump required, but the rest of the change looks good

@noorulkhan-n

Copy link
Copy Markdown
Contributor Author

@clarkd version incremented

Comment thread plugins/Rootly/v1/dataStreams/incidents.json
@github-actions

Copy link
Copy Markdown

🧩 Plugin PR Summary

📦 Modified Plugins

  • plugins/Rootly/v1

📋 Results

Step Status
Validation ❌ Failed
Deployment ⏭️ Skipped

🔍 Validation Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin: Rootly

Development

Successfully merging this pull request may close these issues.

2 participants