Skip to content

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deenk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/devices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,19 @@
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},

Check failure on line 10 in plugins/NinjaOne/v1/dataStreams/devices.json

View check run for this annotation

Claude / Claude Code Review

Missing metadata.json version bump 

This PR modifies 6 data stream files under `plugins/NinjaOne/v1/dataStreams/` but does not bump the version in `plugins/NinjaOne/v1/metadata.json` (still at `1.1.9`). Per the repo's review guidance, any change inside a plugin directory must include a corresponding `metadata.json` version bump; since this is a behavior-affecting paging fix, please add at least a patch bump (e.g. `1.1.9` -> `1.1.10`) before merging.
Comment thread
claude[bot] marked this conversation as resolved.
"expandInnerObjects": true,
"endpointPath": "/v2/devices",
"postRequestScript": "devices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/locationDevices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/devices",
"postRequestScript": "locationDevices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"matches": {
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/locations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/locations",
"postRequestScript": "locations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizationDevices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/organization/{{objects[0].organizationId}}/devices",
"postRequestScript": "devices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"objectLimit": 1,
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizationLocations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/locations",
"postRequestScript": "organizationLocations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"matches": {
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/organizations",
"postRequestScript": "organizations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
Loading