Skip to content

Trailing comments support on windows#2908

Merged
oldergod merged 1 commit intomasterfrom
bquenaudon.2024-04-15.trailingcomments
Apr 22, 2026
Merged

Trailing comments support on windows#2908
oldergod merged 1 commit intomasterfrom
bquenaudon.2024-04-15.trailingcomments

Conversation

@oldergod
Copy link
Copy Markdown
Member

Fixes #2905

@oldergod
Copy link
Copy Markdown
Member Author

Would you have a guess as to why it works @yschimke ?

@oldergod
Copy link
Copy Markdown
Member Author

I guess I should try to read a file on disk...? Or explicitly insert \r\n in the content

@yschimke
Copy link
Copy Markdown

Yeah, try manually inserting windows newlines?

@oldergod oldergod force-pushed the bquenaudon.2024-04-15.trailingcomments branch 2 times, most recently from 29d654f to 0d53db4 Compare April 15, 2024 13:39
@oldergod oldergod force-pushed the bquenaudon.2024-04-15.trailingcomments branch from 0d53db4 to 508f9bb Compare April 20, 2026 13:23
@oldergod oldergod force-pushed the bquenaudon.2024-04-15.trailingcomments branch from 508f9bb to 376a891 Compare April 20, 2026 13:34
@oldergod oldergod marked this pull request as ready for review April 20, 2026 13:35
@oldergod oldergod merged commit d324293 into master Apr 22, 2026
17 checks passed
@oldergod oldergod deleted the bquenaudon.2024-04-15.trailingcomments branch April 22, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto generation fails on Windows with trailing comments

3 participants